Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle kingdom options more explicitly and consistently #55

Open
Aariq opened this issue Nov 26, 2024 · 0 comments
Open

Handle kingdom options more explicitly and consistently #55

Aariq opened this issue Nov 26, 2024 · 0 comments

Comments

@Aariq
Copy link
Collaborator

Aariq commented Nov 26, 2024

npn_species_state() and npn_species_type() both accept a kingdom argument. For both, it can be "Animalia", "Plantae" or NULL. If NULL it returns results for both. I think we should deprecate the NULL option and use

function(kingdom = c("Plantae", "Animalia", "both")) {
     kingdom <- rlang::arg_match(kingdom)
}

Also, the default for npn_species_state() is NULL and the default for npn_species_type() is "Plantae" and it might be good to make these consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant