Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual revision of manually simplified data #231

Closed
anastassiavybornova opened this issue Feb 11, 2025 · 4 comments
Closed

Manual revision of manually simplified data #231

anastassiavybornova opened this issue Feb 11, 2025 · 4 comments
Assignees
Labels

Comments

@anastassiavybornova
Copy link
Collaborator

Issue: manual simplification was done with "old" original data (contaning service roads). the "new" original data (see here: https://github.com/uscuni/simplification/tree/main/data ) has no service roads. so the manually simplified data needs to be checked against it. as a helper we have gpkg files (deltas.gpkg) for each city with a hexagon grid (see here: https://github.com/uscuni/simplification/tree/main/revision , generated by the notebook here: https://github.com/uscuni/simplification/tree/main/notebooks/manual-revision: )

the columns "edge count delta to verify", "node count delta to verify", and "edge length delta to verify" have true/false indicating for each hexagon whether there is a negative value for the metric (ie whether original minus manual is negative) , and the column "to verify total" counts the total number of negative values.

Image

the task is to check for each city those hexagons which have a "to verify total" > 0, and either:
a. correct the manual simplification data OR
b. mark the hexagon as non-problematic

@dancejod
Copy link
Contributor

Finally uploaded the parquets/gpkgs of revised manual simplification and hexagons to branch hexagon-revision.

Also added a new column status to hexagons with values clean, fixed and non-problematic; I marked all of the hexagons accordingly. Wuhan was the most problematic again as per tradition.

The majority of the non-problematic hexagons contain manual simplification identical to the original data with only a minor difference in edge_length_delta. Other than that I hopefully got rid of all service roads.

@anastassiavybornova
Copy link
Collaborator Author

THANK YOU!! @dancejod

so that means it is ready to be merged? will you make a pull request? yay

@anastassiavybornova
Copy link
Collaborator Author

@dancejod do you want to festively close this one? :)

@dancejod
Copy link
Contributor

@anastassiavybornova indeed, sound the trumpets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants