Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra]: Refresh AWS token before each Terraform pipeline stage #570

Open
ClaireSimmonds opened this issue Jan 5, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request github Repository automation and configuration

Comments

@ClaireSimmonds
Copy link

ClaireSimmonds commented Jan 5, 2024

Why is this issue important?

Because the "Deploy to Production" workflow includes a manual step to verify the terraform plan output, it is possible for the AWS token to expire before the "Terraform Apply" job kicks off, depending on how long the manual review takes. This may result in a failed build and deployers needing to re-run the pipeline to produce a successful build. This change will ensure that the token is generated at the beginning of each stage it is needed, which will reduce the need for additional manual effort and better accommodate longer build times in the future.

Current State

The pipeline currently generates the needed AWS credentials just before entering the "Terraform Plan" job. However, the plan needs to be reviewed manually before applying in production environments. This can result in a delay longer than the session time, depending on how long the review takes, and the key may not be valid by the time the "Terraform Apply" job executes.

Expected State

The pipeline will generate necessary AWS credentials for Terraform plan and apply at the beginning of each stage they are used.

Implementation Plan

Update the "Deploy to Production" workflow to:

  1. Rename the current aws-auth job and associated references to aws-auth-plan
  2. Create a new aws-auth-apply job that triggers before the tf-apply job
@TylerHendrickson TylerHendrickson added github Repository automation and configuration enhancement New feature or request labels Jan 9, 2024
@TylerHendrickson TylerHendrickson moved this from 🆕 New to 🔖 Ready in Grants Team Agile Planning Jan 9, 2024
@ClaireSimmonds ClaireSimmonds self-assigned this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github Repository automation and configuration
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants