Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider storing location data by source #202

Open
Mr0grog opened this issue Jun 11, 2021 · 2 comments
Open

Consider storing location data by source #202

Mr0grog opened this issue Jun 11, 2021 · 2 comments
Labels
api enhancement New feature or request

Comments

@Mr0grog
Copy link
Collaborator

Mr0grog commented Jun 11, 2021

We haven’t placed much priority to carefully handling location data, since the primarily useful product we provide has been availability data — for most clients, the location information we have is used to match our availability data to another database on their end, or the amount of location info they show from us is pretty minimal.

However, I’ve recently had to fix some issues in our location data (e.g. bad zip codes), and doing so was not straightforward because we have multiple sources live updating location information. It’s hard to:

  • Know what source bad data is coming from.
  • Override that data manually, since it might get reset in a few minutes when that bad source next sends an update.

It might be useful to have a separate provider_locations_raw table or something that stores the location data received from posts to /update, and stores that data by location_id + source (we could have a special source name, or NULL source for manual updates). Then we could store merged results from all the sources in the existing provider_locations table. (This is sort of like how we handle availability data by source.)

We might also prioritize sources differently when merging. For example, values from the manual/NULL source would win out over values from a state authority (#198) which would win out over Vaccinate the States (#189) which would win out over other more automated sources.

/cc @astonm

@Mr0grog Mr0grog added the question Further information is requested label Jun 11, 2021
@Mr0grog
Copy link
Collaborator Author

Mr0grog commented Jun 18, 2021

Established in this week’s meeting that this sounds like a good idea, but not top priority. However, we may not want to use this mechanism for storing manual overrides: #231.

@Mr0grog Mr0grog added api enhancement New feature or request and removed question Further information is requested labels Jun 18, 2021
@Mr0grog
Copy link
Collaborator Author

Mr0grog commented Jun 19, 2023

This project has been shut down. This issue has been left open as a guide for anyone forking this project — addressing this issue (or at least knowing about it!) is likely to be worthwhile for you if you are maintaining a running copy or fork of UNIVAF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant