-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and clarify event status and start/end date verification #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-d-b
added
Refactor
This item related to refactoring the specification.
Cleanup
This item relates to cleaning up the specification (e.g. removing deprecated items)
labels
Apr 22, 2022
j-d-b
changed the title
Refactor/event status
Refactor and clarify event status and start/end date verification
Apr 22, 2022
j-d-b
commented
Apr 22, 2022
mollybehan
approved these changes
Apr 25, 2022
@j-d-b I thought we discussed at one point but were we planning on still updating the object and enumeration lists in the spec-content README? Or will we just do this when everything is merged? |
sknick-iastate
approved these changes
Jul 7, 2022
jlarsonOmahaNE
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #189. Specifically, it proposes the following changes:
event_status
property on the WorkZoneRoadEvent and DetourRoadEvent.start_date_accuracy
andend_date_accuracy
properties on the WorkZoneRoadEvent and DetourRoadEvent.is_start_date_verified
andis_end_date_verified
to the WorkZoneRoadEvent and DetourRoadEvent to indicate if the work zone or detour has been confirmed to have started/ended by a person or device in the field or report from a TMC, or similar.start_date_accuracy
oris_start_date_verified
.end_date_accuracy
oris_end_date_verified
.is_start_date_verified
andis_end_date_verified
and not useevent_status
,start_date_accuracy
, orend_date_accuracy
.See #281 for a similar approach of using booleans that this PR is consistent with.