Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for custom AccountId to and from string conversions #1014

Closed
ascjones opened this issue Mar 10, 2023 · 1 comment
Closed

Add unit tests for custom AccountId to and from string conversions #1014

ascjones opened this issue Mar 10, 2023 · 1 comment

Comments

@ascjones
Copy link
Collaborator

Follow up to #1010.

This was copied from subxt, which in turn was copied from substrate. The methods to convert to and from SS58 encoded strings are assumed to be correct. We should add some unit tests to double check that and protect against regressions.

@ascjones
Copy link
Collaborator Author

Actually there is already a unit test which covers this: https://github.com/paritytech/cargo-contract/blob/master/crates/transcode/src/account_id.rs#L216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant