Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load private keys into --suri from a file #1106

Open
ltfschoen opened this issue May 10, 2023 · 3 comments
Open

Load private keys into --suri from a file #1106

ltfschoen opened this issue May 10, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@ltfschoen
Copy link

In one of the YouTube videos by Andrew Jones, he mentioned that instead of uploading a contract with cargo contract upload --suri //Alice for example, it was preferable to use the contracts-ui to avoid exposing private key (if it wasn't one of the build-in accounts).

Are we able to populate the private keys into a text file and interpret its contents via the ``suri` option of the cargo contract command similar to like i did here

@ascjones
Copy link
Collaborator

Yes please Luke. I don't have time to do this in the near future but would love to see it if anyone wants to pick it up!

rel. #674

@ltfschoen
Copy link
Author

ltfschoen commented May 28, 2023

Yes please Luke. I don't have time to do this in the near future but would love to see it if anyone wants to pick it up!

rel. #674

@ascjones I've tried to do it in this PR #1134 and it seems to be working fine, just needs some feedback and more cleaning up after that, is that what you were after?

@ltfschoen
Copy link
Author

ltfschoen commented May 10, 2024

@ascjones FYI, i don't think this is a necessary feature since you can just load the secrets from an environment variable using a bash script or similar like this https://github.com/ltfschoen/validator-scripts?tab=readme-ov-file#rotate-validator-session-keys-with-via-cli-with-polkadotjs-tools-instead-of-via-ui-with-polkadotjs-apps, which saved having to add this feature polkadot-js/tools#82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants