Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with polkadot-v0.9.31 and later Substrate #371

Closed
jasl opened this issue Oct 22, 2022 · 6 comments · Fixed by #374
Closed

Not compatible with polkadot-v0.9.31 and later Substrate #371

jasl opened this issue Oct 22, 2022 · 6 comments · Fixed by #374

Comments

@jasl
Copy link

jasl commented Oct 22, 2022

Trying contracts-ui with Substrate Node polkadot-v0.9.31 and later will lead node runtime panic, probably relates to paritytech/substrate#12429

I already created an issue for Substrate paritytech/substrate#12548

@athei
Copy link
Contributor

athei commented Oct 23, 2022

Supported for this is already in polkadot.js:
https://github.com/polkadot-js/api/blob/master/CHANGELOG.md#951-oct-8-2022

@jasl
Copy link
Author

jasl commented Oct 23, 2022

Supported for this is already in polkadot.js: https://github.com/polkadot-js/api/blob/master/CHANGELOG.md#951-oct-8-2022

So conracts-ui just need to upgrade polkadot.js dependency? I tried master branch it's also failed.

@statictype
Copy link
Contributor

It might me more than just an upgrade, this is a major breaking change. Not clear if polkadot.js/api supports Weightv2 for runtime calls and RPCs or only for transactions and how it handles backward compatibility. Will look into it asap.

@statictype
Copy link
Contributor

@jasl there is no easy way to do this without breaking older nodes. will have to display a new input if the node supports WeightV2 and also encode/decode dry run results differently depending if the node supports V1, V2 or V1,5.
Most likely will have this early next week (on holiday atm)

@jasl
Copy link
Author

jasl commented Oct 25, 2022

@jasl there is no easy way to do this without breaking older nodes. will have to display a new input if the node supports WeightV2 and also encode/decode dry run results differently depending if the node supports V1, V2 or V1,5. Most likely will have this early next week (on holiday atm)

Understood, no rush, Polkadot v0.9.31 release should 3 weeks later

@jasl
Copy link
Author

jasl commented Nov 13, 2022

https://github.com/polkadot-js/api/releases/tag/v9.8.1 is released!

Note: I PR Substrate for marking contracts API api_version(2), I backported to 0.9.33 and 0.9.32 only, 0.9.31 is released before the PR, so people may experience bug behavior.

@statictype statictype changed the title Doesn't compatible with polkadot-v0.9.31 and later Substrate Not compatible with polkadot-v0.9.31 and later Substrate Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants