Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E testing: Fetch runtime metadata automatically #1422

Closed
cmichi opened this issue Sep 28, 2022 · 0 comments · Fixed by #1526
Closed

E2E testing: Fetch runtime metadata automatically #1422

cmichi opened this issue Sep 28, 2022 · 0 comments · Fixed by #1526
Assignees
Labels
A-ink_env [ink_env] work item

Comments

@cmichi
Copy link
Collaborator

cmichi commented Sep 28, 2022

Follow-up to #1395.

The current E2E testing framework still contains a hardcoded

#[subxt::subxt(runtime_metadata_path = "metadata/contracts-node.scale")]
pub(super) mod api {}

Instead of requiring this test fixture in the ink repository (exported via subxt metadata > contracts-node.scale while the node is running), we should fetch it automatically, getting rid of requiring users to do this step.

With paritytech/subxt@d03e599, subxt got the possibility of supplying a

#[subxt::subxt(runtime_metadata_url = "wss://rpc.polkadot.io:443")]

We already support #[ink_e2e::test(ws_url = "…")], so ideally we would use that supplied URL for the runtime_metadata_url.

@cmichi cmichi added the A-ink_env [ink_env] work item label Sep 28, 2022
@cmichi cmichi self-assigned this Sep 28, 2022
@cmichi cmichi moved this to Backlog 🗒 in Smart Contracts Sep 28, 2022
@cmichi cmichi assigned ascjones and unassigned cmichi Nov 5, 2022
Repository owner moved this from Backlog 🗒 to Done ✅ in Smart Contracts Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ink_env [ink_env] work item
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants