Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReturnTypeSpec should take a TypeSpec directly #1515

Closed
HCastano opened this issue Nov 23, 2022 · 1 comment · Fixed by #1999
Closed

ReturnTypeSpec should take a TypeSpec directly #1515

HCastano opened this issue Nov 23, 2022 · 1 comment · Fixed by #1999
Assignees
@SkymanOne
Labels
A-ink_metadata [ink_metadata] Work item

Comments

@HCastano
Copy link
Contributor

Right now ReturnTypeSpec expects an Option to be passed indicating whether or not a function returns something.

With recent changes related to #1450 and #1504 all messages and constructors now return a value,so there's no need to have ReturnTypeSpec expect an Option.

Related discussion here.
@HCastano HCastano added the A-ink_metadata [ink_metadata] Work item label Nov 23, 2022
@HCastano HCastano mentioned this issue Nov 23, 2022
Merged
2 tasks
@xermicus
Copy link
Contributor

xermicus commented Nov 23, 2022 •
edited
Loading

Also related, I sketched a possible approach here.

@SkymanOne SkymanOne self-assigned this Nov 17, 2023
@SkymanOne SkymanOne mentioned this issue Nov 17, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SkymanOne SkymanOne

Labels
A-ink_metadata [ink_metadata] Work item
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Messages return TypeSpec directly use-ink/ink
3 participants
@xermicus @HCastano @SkymanOne