Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace api::set_code_hash with api::set_code_hash2 impl #1701

Closed
ascjones opened this issue Mar 3, 2023 · 1 comment
Closed

Replace api::set_code_hash with api::set_code_hash2 impl #1701

ascjones opened this issue Mar 3, 2023 · 1 comment
Labels
A-ink_env [ink_env] work item

Comments

@ascjones
Copy link
Collaborator

ascjones commented Mar 3, 2023

The existing set_code_hash impl accepts the concrete &[u8; 32], which is different to other api methods handling code hashes which use the generic E::Hash type.

In order not to make a breaking change, I have proposed adding a new set_code_hash2 method to the api which accepts the generic E::Hash instead.

This ticket is a reminder to replace the set_code_hash impl with set_code_hash2 impl at the next MAJOR release.
@ascjones ascjones added the A-ink_env [ink_env] work item label Mar 3, 2023
@ascjones ascjones mentioned this issue Mar 3, 2023
Merged
@goastler goastler mentioned this issue Mar 22, 2023
Open
@ascjones
Copy link
Collaborator Author

Closed by #1906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ink_env [ink_env] work item
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ascjones