Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request with no changes save loops #3316

Open
2 tasks done
MWDidata opened this issue Oct 16, 2024 · 2 comments · May be fixed by #3346
Open
2 tasks done

Request with no changes save loops #3316

MWDidata opened this issue Oct 16, 2024 · 2 comments · May be fixed by #3346
Assignees
@anusreesubash
Labels
bug Something isn't working module-request short-term-goal

Comments

@MWDidata
Copy link

I have checked the following:

  • I use the newest version of bruno.
  • I've searched existing issues and found nothing related to my issue.

Describe the bug

After making a change to a request and reverting that change Bruno think the request has changes.
After saving those non-changes Bruno still thinks there are changes that need to be saved.

When closing the request Bruno asks to save unsaved changes, after then opening the request again Bruno still says there are changes

.bru file to reproduce the bug

Any request add a space and remove said space

Screenshots/Live demo link

image
@MWDidata MWDidata added the bug Something isn't working label Oct 16, 2024
@rreyn-bruno
Copy link
Collaborator

@MWDidata - thanks for submitting. I've created a repro of what you describe below.

For the Bruno team, here are the comprehensive steps:

  • Open collection
  • Make any modification (typing a letter/character, deleting a letter/character)
  • Manually revert that modification (delete typed letter/character, replace deleted letter/character)
  • Press save
  • Attempt to close application/collection
3316repro.mp4

@anusreesubash anusreesubash self-assigned this Oct 24, 2024
@anusreesubash anusreesubash linked a pull request Oct 24, 2024 that will close this issue
Open
5 tasks
@venk404
Copy link

venk404 commented Oct 25, 2024

Hey @anusreesubash

I reviewed the changes you made, including the extra line, but it seems the pop-up is still appearing, so the issue may not be fully resolved yet. If you could take another look, I’d really appreciate it. Please see the video attached. Thank you!

@sreelakshmi-bruno sreelakshmi-bruno mentioned this issue Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anusreesubash anusreesubash

Labels
bug Something isn't working module-request short-term-goal
Projects
None yet
Milestone
No milestone
5 participants
@venk404 @anusreesubash @MWDidata @rreyn-bruno @sreelakshmi-bruno