Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Disabling SSL doesn't seem to work #362

Closed
deanveloper opened this issue Oct 4, 2023 · 15 comments · Fixed by #725
Closed

[Bug] Disabling SSL doesn't seem to work #362

deanveloper opened this issue Oct 4, 2023 · 15 comments · Fixed by #725

Comments

@deanveloper
Copy link

At the company I work for, we use self-signed certificates for our development environment. In Postman, we need to add our own CA, which is done (in postman) via Settings > Certificates > CA Certificates > PEM File.

It doesn't appear that bruno supports this, although there is an option to disable SSL Certificate Authentication. But when I do that, I get the error Error invoking remote method 'send-http-request': Error: Key is required.

@TbirdDuncan
Copy link

I'm also experiencing this issue

@lared
Copy link
Contributor

lared commented Oct 4, 2023

Can you replicate it with any of those domains?

https://badssl.com/

@TbirdDuncan
Copy link

TbirdDuncan commented Oct 4, 2023

Resolved it. There's no documentation on this except for #168. You go to the bottom left of the app and theres a tiny gear cog with the options to disable ssl. I realize now, that I've posted to a thread thats maybe, a bit off topic haha. Sounds like deanveloper already disabled ssl.

@deanveloper
Copy link
Author

deanveloper commented Oct 4, 2023

Can you replicate it with any of those domains?

https://badssl.com/

@lared Unfortunately not. Not sure if it's at all helpful, but the error that I get when connecting to our development environment with SSL enabled is Error invoking remote method 'send-http-request': Error: unable to verify the first certificate

@Lotti
Copy link

Lotti commented Oct 9, 2023

@deanveloper you just have to do a get call to https://self-signed.badssl.com/ to reproduce the problem.

Disabling SSL self-signed check doesn't work (I used the cog in the bottom left corner)

@helloanoop
Copy link
Contributor

@Lotti Are you on the latest version v0.22.0 ?

This is working on my system. MacOS Moneterey Intel x64

image

@Lotti
Copy link

Lotti commented Oct 9, 2023

Thank you for your fast reply.
I'm running in windows 10 with v0.22.0 portable (installed this morning to replace postman)

@helloanoop
Copy link
Contributor

Can you join our discord community. I'll ask our windows user there to check this if they are experiencing the same.

@deanveloper
Copy link
Author

deanveloper commented Oct 10, 2023

Can the findings be posted here? It'd be nice to have any findings posted in an indexable/archivable location

@Lotti
Copy link

Lotti commented Oct 10, 2023

We find out that the bug exists only when using a proxy

@lllama
Copy link

lllama commented Oct 16, 2023

Echoing what @Lotti says: if I enable a proxy (Burp in this case) then I get the cert error.

@cwilper
Copy link
Contributor

cwilper commented Oct 16, 2023

I got the same issue when using a proxy that self-signs certs in proxied HTTPs traffic, even after "SSL Certificate Verification" is un-checked. This is still happening as of v0.25.0.

Workaround:

What worked for me was to set the NODE_TLS_REJECT_UNAUTHORIZED env var to 0 before running.

For example, on macOS, launch the UI from Terminal via:

NODE_TLS_REJECT_UNAUTHORIZED=0 open -a Bruno.app

@lllama
Copy link

lllama commented Oct 18, 2023

Thanks @cwilper

For Windows people:

❯ $env:NODE_TLS_REJECT_UNAUTHORIZED=0
❯ & 'C:\Users\<YOUR_USER>\AppData\Local\Programs\bruno\Bruno.exe'

@ebricca
Copy link

ebricca commented Oct 20, 2023

on preference save error

one has to set the proxy.port to a number e.g. 1000 even when not used

( output from devtools :)
Error: Error invoking remote method 'renderer:save-preferences': ValidationError: proxy.port must be a number type, but the final value was: NaN (cast from the value ""). )

@helloanoop
Copy link
Contributor

@Lotti @lllama @ebricca @deanveloper
The issue of SSL Disabling not working when used with proxies has been fixed by @cwilper and is available in v0.27.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants