Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add row clone button to headers tables #3650

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BenSnellgrove
Copy link

@BenSnellgrove BenSnellgrove commented Dec 14, 2024

Description

Resolves #3649
As in #3649, a button to clone a row in the header table
Row cloned is placed at the bottom of the table, and contains all attributes of the row

For parity, code exists for:

  • request
  • folder
  • collection

I'm not familiar with tailwind, and I'm happy for changes to be made to my crude usage of   to space the buttons, as I'm sure such a solution exists

Existing state:
image

After changes:

Request:
image

Folder:
image

Collection:
image

I'd like to add that the level of code duplication in the project makes it unwelcoming to contribute too. It is also one of the reasons that this PR is only for headers, as covering every row usage (that I can see) expands a simple change to 9 different cases, which could reasonably be two or three, and code tallying well over 100 lines. That is not a small change in my view

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@BenSnellgrove BenSnellgrove changed the title feature: feature: Add row clone button to headers tables Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add header clone button
1 participant