Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight skipped requests in UI #3765

Open
1 task done
nikischin opened this issue Jan 8, 2025 · 3 comments · May be fixed by #3853
Open
1 task done

Highlight skipped requests in UI #3765

nikischin opened this issue Jan 8, 2025 · 3 comments · May be fixed by #3853
Assignees
@sreelakshmi-bruno
Labels
enhancement New feature or request short-term-goal

Comments

@nikischin
Copy link
Contributor

nikischin commented Jan 8, 2025 •
edited
Loading

I have checked the following:

  • I've searched existing issues and found nothing related to my issue.

Describe the feature you want to add

As mentioned in #2397 it would be great to highlight skipped requests in the UI. The new functionality is cool, but when running many requests, I need to always calculate how many requests were skipped. I would love to see this at a glance. Therefore @JorgeTrovisco implemented some beautiful UI already in #2397 with the feedback of some other users. This keeps the UI more consistent and clean.

Mockups or Images of the feature

Count Skipped requests:

400217775-be246688-4b1b-4914-9c08-296228d1ede2

Single Request

Instead of current implementation (which looks too similar to failed requests):
400217605-6311a2be-c3d5-49fc-b483-b9c61916a7d1

Let's rather implement this:
400217672-a15f61cf-c49c-4bdd-ad57-69e1b501b051

Images by @JorgeTrovisco
@nikischin nikischin added the enhancement New feature or request label Jan 8, 2025
@nikischin nikischin mentioned this issue Jan 8, 2025
Closed
5 tasks
@JorgeTrovisco
Copy link

JorgeTrovisco commented Jan 9, 2025 •
edited
Loading

@nikischin, it seems the images haven’t loaded correctly. Could you please reupload them?

Regarding the feature, since it was implemented in the previous PR without input from the repository owners, I’m unsure how to proceed. I assume they might prefer to handle its implementation themselves.

@nikischin
Copy link
Contributor Author

@nikischin, it seems the images haven’t loaded correctly. Could you please reupload them?

Regarding the feature, since it was implemented in the previous PR without input from the repository owners, I’m unsure how to proceed. I assume they might prefer to handle its implementation themselves.

Thank you, I just reuploaded them, could you confirm you can see them? :)

And yes I cannot agree more with what you said unfortunately.

@sreelakshmi-bruno sreelakshmi-bruno self-assigned this Jan 15, 2025
@sreelakshmi-bruno
Copy link
Collaborator

sreelakshmi-bruno commented Jan 15, 2025 •
edited
Loading

Hi @nikischin, thanks for reporting, @JorgeTrovisco , please add a comment here when you have a PR. We'll look into it. Thanks!

@nikischin nikischin linked a pull request Jan 21, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sreelakshmi-bruno sreelakshmi-bruno

Labels
enhancement New feature or request short-term-goal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Styled skipped requests nikischin/bruno
3 participants
@JorgeTrovisco @nikischin @sreelakshmi-bruno