Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow_password_login option is gone #3719

Closed
petrm opened this issue Jul 19, 2024 · 8 comments
Closed

disallow_password_login option is gone #3719

petrm opened this issue Jul 19, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@petrm
Copy link

petrm commented Jul 19, 2024

Describe the bug

Latest release v0.22.3 moved the the option to disable registration to the configuration via environment variable. Same pull request also removed the possibility to disallow password loging and only leave SSO on.
Please bring back SSO-only login.

Steps to reproduce

N/A option is not available anymore

The version of Memos you're using.

v0.22.3

Screenshots or additional context

No response

@petrm petrm added the bug Something isn't working label Jul 19, 2024
@MFYDev
Copy link

MFYDev commented Jul 20, 2024

Met the same issue here

@tanpro260196
Copy link

Please bring this back, I don't want to potentially expose my host account to normal user.

@Westwall98
Copy link

Need disallow_password_login. Please bring it back

1 similar comment
@EriTang
Copy link

EriTang commented Jul 26, 2024

Need disallow_password_login. Please bring it back

@boojack boojack added enhancement New feature or request and removed bug Something isn't working labels Jul 27, 2024
@boojack
Copy link
Member

boojack commented Jul 27, 2024

Updated with 8bf7cdf

@boojack boojack closed this as completed Jul 27, 2024
@Jayspek
Copy link

Jayspek commented Aug 2, 2024

When I start it with the --password-auth false, it still says "password-auth: true" in the startup information, and I am still able to log in with a password. Seems to be broken?

@boojack
Copy link
Member

boojack commented Aug 12, 2024

my_application -debug=false -another_boolean_param=boolean_value

@Jayspek Refer to https://stackoverflow.com/a/27411724

@Jayspek
Copy link

Jayspek commented Aug 13, 2024

My bad, thanks for the pointer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants