Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade memo 23.2 > 24.2 MYSQL error : Can't drop column tags. #4368

Closed
activ8xpgithub opened this issue Feb 5, 2025 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@activ8xpgithub
Copy link

Describe the bug

ERROR failed to migrate error="Error 1091 (42000): Can't DROP COLUMN tags; check that it exists\nfailed to execute statement\ngithub.com/usememos/memos/store.(*Store).execute\n\t/backend-build/store/

Steps to reproduce

upgrade docker from 23.2 to latest

The version of Memos you're using

23.2

Screenshots or additional context

No response

@activ8xpgithub activ8xpgithub added the bug Something isn't working label Feb 5, 2025
@shagr4th
Copy link
Contributor

shagr4th commented Feb 5, 2025

duplicate of #4365 , which is the error at the first container start. This error is showing at the second restart and is a consequence of the first failure

@johnnyjoygh
Copy link
Collaborator

which is the error at the first container start. This error is showing at the second restart and is a consequence of the first failure

All migration scripts(in a same version) of memos will be executed within a transaction, and it will only commit after everything is completed. So it shouldn’t be related to the count of server starts.

https://github.com/usememos/memos/blob/main/store/migrator.go#L94

@shagr4th
Copy link
Contributor

shagr4th commented Feb 6, 2025

All migration scripts(in a same version) of memos will be executed within a transaction, and it will only commit after everything is completed. So it shouldn’t be related to the count of server starts.

Most DDL queries are auto-commited by defaut, you can't encapsulate several of them in a single transaction

@johnnyjoygh
Copy link
Collaborator

@shagr4th Thanks, TIL.

@activ8xpgithub
Copy link
Author

So, I am not sure how to fix, going back to 23.1 it's fine, but every time I pull down stable or latest I still get the same
error of can't drop column tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants