Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direction Ascending not working #4371

Closed
ivanov opened this issue Feb 6, 2025 · 2 comments
Closed

Direction Ascending not working #4371

ivanov opened this issue Feb 6, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ivanov
Copy link

ivanov commented Feb 6, 2025

Describe the bug

setting the ascending order direction only works on data loaded with descending order initially, and returns no results if it is the initial setting on page load.

Steps to reproduce

  1. to go to https://demo.usememos.com/auth and login
  2. click on the settings icon at the right edge of the "Search memos" input
  3. change Direction to Ascending (the loaded memos are properly reordered.
  4. observe that the URL is https://demo.usememos.com/?orderBy=asc and reload
  5. no items show up, a spinner keeps spinning indefinitely.

The version of Memos you're using

demo

Screenshots or additional context

javascript console error:

app.Cqhkrlla.js:279 Uncaught (in promise) ClientError: /memos.api.v1.MemoService/ListMemos INVALID_ARGUMENT: failed to build find memos with filter: rpc error: code = InvalidArgument desc = invalid filter: found issue ERROR: <input>:1:1: undeclared reference to 'order_by_time_asc' (in container '')
 | order_by_time_asc == true
 | ^
    at s (app.Cqhkrlla.js:279:4865)
    at async f (app.Cqhkrlla.js:279:8975)
    at async Object.listMemos (app.Cqhkrlla.js:279:9383)
    at async Object.fetchMemos (app.Cqhkrlla.js:280:162390)
    at async c (app.Cqhkrlla.js:1157:4064)
    at async u (app.Cqhkrlla.js:1157:4376)

@ivanov ivanov added the bug Something isn't working label Feb 6, 2025
@johnnyjoygh johnnyjoygh self-assigned this Feb 6, 2025
@johnnyjoygh
Copy link
Collaborator

Thanks for the information, I’ll handle this.

@johnnyjoygh
Copy link
Collaborator

Fixed with 849bf66, you can pull the stable image again to validate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants