Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bypass PHP class inheritance when adding command to bake #1021

Closed
lcharette opened this issue Jul 28, 2019 · 2 comments
Closed

Bypass PHP class inheritance when adding command to bake #1021

lcharette opened this issue Jul 28, 2019 · 2 comments
Labels
bakery Related to the Bakery feature
Milestone
5.0.0

Comments

@lcharette
Copy link
Member

PHP class inheritance means a custom sprinkle that wants to add custom command to the main bake command need to chain the right class extension. For example, account already extend core, so your sprinkle need to extend account. This can introduce a problem with community sprinkle. A new method (register ?) might be necessary here.
@lcharette lcharette added the bakery Related to the Bakery feature label Jul 28, 2019
@lcharette lcharette added this to the 5.0 milestone Jul 28, 2019
@lcharette lcharette mentioned this issue May 3, 2020
Closed
@lcharette
Copy link
Member Author

Events are now used in 5.0 to customize the bake command. Same will be done for setup and debug command. See userfrosting/sprinkle-core@b1d57e6

@lcharette
Copy link
Member Author

Release in 5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bakery Related to the Bakery feature
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@lcharette