-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ordering by activity date #1062
Conversation
Some activity logs can occur at the same second, so ordering just by date can show the results unordered. As per @lcharette suggestion, we can order by `occurred_at` AND `id`. That should gives better results.
Codecov Report
@@ Coverage Diff @@
## develop #1062 +/- ##
===========================================
+ Coverage 66.79% 67.79% +1%
- Complexity 1933 1983 +50
===========================================
Files 162 172 +10
Lines 6748 6930 +182
===========================================
+ Hits 4507 4698 +191
+ Misses 2241 2232 -9
Continue to review full report at Codecov.
|
The style issue will need to be updated first : https://github.styleci.io/analyses/OML5Lk?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
@lcharette I re-added the whitespace but it's giving two fails. Do you know what could be happening? |
Nan, you need to remove the whitespace. FYI, Codecov failure can be ignored |
@lcharette Should be done now |
Some activity logs can occur at the same second, so ordering just by date can show the results unordered. As per @lcharette suggestion, we can order by
occurred_at
ANDid
. That should gives better results.