Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprunje Bug fix and Docker updates #1073

Closed
wants to merge 4 commits into from
Closed

Sprunje Bug fix and Docker updates #1073

wants to merge 4 commits into from

Conversation

ssnukala
Copy link
Contributor

  1. Fixes Sprunje applyTransformations method not returning the $collections object #1068
  2. Docker Changes

1. Added Node definition to Docker Image
2. Added reverse proxy so we can launch the site using http://userfrosting.localhost instead of using http://localhost::port
@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #1073 into master will not change coverage by %.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1073   +/-   ##
=========================================
  Coverage     67.57%   67.57%           
  Complexity     1976     1976           
=========================================
  Files           170      170           
  Lines          6917     6917           
=========================================
  Hits           4674     4674           
  Misses         2243     2243           
Impacted Files Coverage Δ Complexity Δ
app/sprinkles/core/src/Sprunje/Sprunje.php 55.94% <33.33%> (ø) 47.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c62790e...f404346. Read the comment docs.

@lcharette
Copy link
Member

Could you split this PR in two? Sprunje fix can be merged, but not so sure about Docker, it needs more approval. Thanks !

@Silic0nS0ldier
Copy link
Member

Docker I would do in a separate PR. Docker change could break peoples workflows, a closer inspection is needed which would hold up the Sprunje fix.

@ssnukala
Copy link
Contributor Author

ssnukala commented Apr 5, 2020

Ok I will split it, I should have done this separately in the first place - sorry

@ssnukala ssnukala closed this Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sprunje applyTransformations method not returning the $collections object
3 participants