-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload profile picture/avatar #620
Comments
Definitely. The Default profile picture does injustice to my face. |
I think the avatar system should be organized using "avatar providers". This would allows devs to manage ways an avatar can be defined. For instance a dev could want to remove Gravatar and keep only file upload. So I'm guessing a sub-servicesProvider could work ? Something like We need to take into consideration that a provider should be self contained within a sprinkle, ideally in plug and play fashion. Adding the "Gravatar" sprinkle should automatically add it to the provider list and end user "choose your avatar" form. Some avatar support would still be needed in the To keep existing Gravatar support, a new Gravatar sprinkle should be included in the default UF Install and added to the sprinkle list, to allows a dev to remove such support easily. This would be a new BC. A default UF install should support:
For file upload, either we store the files in the corresponding sprinkle, or provide a global UF place to store all kind of upload. I think a global storage place would be best for backup purposes. A new default storage manager sprinkle could also be created for that, so the location could be changed to a AWS/GoogleDrive/Dropbox/other vendor if needed. |
That sounds good 👍. I think as far as storage goes, it should definitely be outside the sprinkle system with a global directory. There should be a sub directory for each user and maybe move each users temp files over there too. I'm not sure if supporting cloud locations out of the box is a good idea because it could potentially be a high maintenance spot for uf. It would be a nice feature to have in a separate community sprinkle though. |
Cloud storage is supported by Laravel, so if we build it on top of that, we should be fine :D |
But we are not using Laravel... Unless it can be broken off like eloquent? |
We are already using Filesystem. See https://laravel.com/docs/5.5/filesystem And I was thinking about Should it be |
I think we should keep sprinkles out of it and have it based on users. So |
Should persistent data be kept inside Or is there some established convention I'm missing here? |
I don't think there's a technical limitation saying we can't put it to the root. Ping @alexweissman. We need your wisdom |
My primary UF project doesn't have inter-user social functions, and in UF4 I simply disabled the Gravatar lookup. |
Ref #192.
Right now, V4 supports this on a very basic level with gravatar. Would be good if we could upload an image, perhaps with some client-side sizing/crop tool, as another option.
The text was updated successfully, but these errors were encountered: