Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Replace "visible to" with Published/Under review/Archived #1281

Closed
8 tasks done
rjmackay opened this issue Jul 4, 2016 · 11 comments
Closed
8 tasks done

Feature: Replace "visible to" with Published/Under review/Archived #1281

rjmackay opened this issue Jul 4, 2016 · 11 comments
Assignees
Milestone

Comments

@rjmackay
Copy link
Contributor

rjmackay commented Jul 4, 2016

Changes:

  • Update post status display with new icons/text
  • Update post filters to filter by status, not visible to
  • Update post edit with control to set status, remove visibility control
  • Add "Mark as" dropdown to timeline bulk actions (excluding spam/duplicate)
  • Update post actions dropdown to add Put under review/archive/publish options
  • Update post detail and post edit layouts
  • API: Add "archived" status
  • API: Migrate posts already published to specific roles??
    • Run data to see how many this is.
    • Possibly push all these posts back into draft and add to a collection for admin review.

Background: #1263 (comment)


The idea is basically this: From a user-facing point of view, let's scrap "Who can see this," and instead double down on "Post status." A post that's saved within a deployment is either:

  • Published
  • Under review
  • Archived

Any user needs around the fine-tuned visibility of posts will therefore have to be constrained to Role configuration. This effects, well, a lot of screens. But here's the jist of it:

Postcards

Anywhere you see a postcard (including as a map popup, in the Timeline, and post detail), you'll see a consistent email-like treatment of its "status."

Example:
postcards

In the top-left of the postcard, a status indicator is displayed with one of the three status icons. If it's "Under review," it glows yellow (similar to an "unread" indicator), suggesting it requires attention. Otherwise, it's a subtle icon.

If you mouseover it, a short description of the status appears:

mouseover

You can, of course, change a post's status when you edit it. But you can also change its status from:

  1. The listing toolbar:
    listing toolbar
  2. The post's actions dropdown:
    actions dropdown

The status-related actions available correspond to the post's current status.

Map & Timeline

The tools we provide for mashing up the data you're looking are naturally affected by this.
the toolbar's more exhaustive "Filters" control also includes this feature:

searchbar

Post edit

The example I've staged also assumes the user can edit the post time (and author). But you can see there's a very visible control there for changing the post's status:

post edit

@rjmackay
Copy link
Contributor Author

rjmackay commented Aug 4, 2016

@brandonrosage @jshorland what should the default status filter be? show everything? or just published? or published+under review?

@rjmackay
Copy link
Contributor Author

rjmackay commented Aug 4, 2016

Running stats on number of posts published with custom 'published_to' values.

@rjmackay rjmackay reopened this Aug 4, 2016
@rjmackay rjmackay assigned jshorland and unassigned jasonmule Aug 4, 2016
@rjmackay
Copy link
Contributor Author

rjmackay commented Aug 4, 2016

@jshorland this is deployed to ushahididev.com - can you test there? it covers a lot of areas of the UI

To test:

  • Post status display matches PL on timeline
  • Post status display matches PL on map
  • Post status display matches PL on post detail
  • Filter by status works
  • post edit set status control works
  • Bulk actions "mark as under review, archived, published" works
  • Individual post actions dropdown "Put under review/archive/publish" works
  • Post edit sidebar shows created/updated dates

@jshorland
Copy link

QA FAILED.
QA'd on qa.ushahididev.com, u: jess@ushahidi.com, p: password. testing while logged in as ADMIN.

Filter by status:

  • there's some weird behavior here. When I uncheck all three statuses (stati?), there are still posts on the map as well as on list. Is this the way it's supposed to behave?

Bulk actions:

  • when I select all on timeline mode and mark all as "under review", they disappear and timeline mode tells me there are no posts in the deployment yet. I then navigated to the map and all the posts were gone, but the post count numbers are still there. I'm logged in as an admin while testing.
  • when I select all on timeline mode and mark all as "archived", they appear to change to the published indicator icon instead of archived icon.

Post edit sidebar shows created/updated dates:

  • I couldn't test this because I couldn't access any of my posts after bulk action changing them to under review. where did they go?

@jshorland
Copy link

Assigning back to you, @rjmackay -- failed QA.

@rjmackay
Copy link
Contributor Author

rjmackay commented Aug 7, 2016

there's some weird behavior here. When I uncheck all three statuses (stati?), there are still posts on the map as well as on list. Is this the way it's supposed to behave?

With all of our filters, no filter = return anything. The UI doesn't really match this but I'm not sure what it should do. Returning an empty list is pointless..

I'll investigate other issues.

@rjmackay
Copy link
Contributor Author

rjmackay commented Aug 7, 2016

@jshorland can you put these back into "In Development" column when they fail QA?

@rjmackay
Copy link
Contributor Author

rjmackay commented Aug 9, 2016

when I select all on timeline mode and mark all as "under review", they disappear and timeline mode tells me there are no posts in the deployment yet. I then navigated to the map and all the posts were gone, but the post count numbers are still there. I'm logged in as an admin while testing.

I can't reproduce this. We refresh the listing after a 'mark all' but its working fine for me.

when I select all on timeline mode and mark all as "archived", they appear to change to the published indicator icon instead of archived icon.

Can't reproduce this at all

@rjmackay
Copy link
Contributor Author

rjmackay commented Aug 9, 2016

I'm not 100% clear: who can see archived posts? I'm going to assume everyone but we can fix that later if that wasn't desired. @brandonrosage @jshorland

@brandonrosage
Copy link

@rjmackay My intent is for “Archived” posts’ visibility to be identical to that of posts that are “Under Review.”

If nothing else, this keeps things simple.

Until we learn of a user need to expose “Archived” posts publicly, I think we should treat them as posts the deployer explicitly wants to “retire” from the outward-facing dataset, without being forced to either delete or demote them back to “Under Review."

@jshorland
Copy link

Passes QA! Moving to done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants