Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed video preview in post summary box on map #1506

Closed
jshorland opened this issue Nov 15, 2016 · 2 comments
Closed

Embed video preview in post summary box on map #1506

jshorland opened this issue Nov 15, 2016 · 2 comments

Comments

@jshorland
Copy link

jshorland commented Nov 15, 2016

embed should be in post summary box on map, as we do for pictures. This is a new issue produced by original embed #1452 as it was out of scope of original issue.

@willdoran is concerned about performance issues, so he proposed only a preview image and then load only when it is clicked.

@brandonrosage thoughts?

Aha! Link: https://ushahiditeam.aha.io/features/PROD-653

@brandonrosage
Copy link

The "free-form surveys" ethos is for the fields that appear in postcards to be manually chosen. I recognize that's a few months from being realized.

In any case, I'd recommend video embeds only be included in postcards if they can be presented in that context with keyframe images, with an overlaid "play" button that, when clicked, replaces the image with the embed and cues the video.

@brandonrosage
Copy link

I've pushed some support inside the .video_embed-fluid pattern for the aforementioned keyframe image + play button. It makes it possible to replace the iframe inside it with the keyframe image and play button, which would use the interaction logic I described above.

Here's an HTML example:

<div class="video_embed-fluid">
    <button class="button-beta video_embed-button">
        <svg class="iconic">
          <use xlink:href="../../img/iconic-sprite.svg#media-play"></use>
        </svg>
        <span class="button-label hidden">Play video</span>
    </button>
    <img src="https://i.ytimg.com/vi/Gt9fqKG-oiI/hqdefault.jpg?custom=true&w=168&h=94&stc=true&jpg444=true&jpgq=90&sp=68&sigh=-fh34fq0gkIb6RkHIYHHqgs66mI" />
</div>

@jshorland jshorland added 7 and removed Icebox labels Aug 30, 2017
@jshorland jshorland added this to the UX low hanging fruit milestone Aug 30, 2017
@zube zube bot removed the Icebox label Jan 29, 2018
@rowasc rowasc removed this from the UX clean up milestone Sep 13, 2018
@rowasc rowasc added this to the Parking Lot milestone Sep 4, 2020
@Angamanga Angamanga added the Community Task Issues that the Ushahidi OSS community is encouraged to contribute to label Oct 16, 2020
@Angamanga Angamanga removed the Community Task Issues that the Ushahidi OSS community is encouraged to contribute to label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants