Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

title and description field deletion #1697

Closed
MazenBaroudi opened this issue Apr 18, 2017 · 13 comments
Closed

title and description field deletion #1697

MazenBaroudi opened this issue Apr 18, 2017 · 13 comments
Assignees

Comments

@MazenBaroudi
Copy link

MazenBaroudi commented Apr 18, 2017

Expected behaviour: when deleting the "title" and the "description" fields in a survey, they should not appear when somebody wants to add a post

Actual behaviour: even after the deletion, these two fields continue to appear in the survey as a mandatory fields whenever someone is adding a post

Steps to reproduce the behaviour/error

@aoduor
Copy link
Member

aoduor commented Apr 18, 2017

@MazenBaroudi
Copy link
Author

Problem not solved yet 😞

@jshorland
Copy link

@MazenBaroudi -- we're continuing to look into it!

@rjmackay
Copy link
Contributor

@willdoran can you look into whether we really allowed removing title + description in the API? ... assuming the API side is all fine, then @crcommons can dig into the client side

@willdoran
Copy link
Contributor

@rjmackay Yep, will look now, I don't remember us allowing deletion of those fields but will check through the code.

@willdoran
Copy link
Contributor

@rjmackay Actually we don't have delete validators at all for form attributes so through the api you can delete whatever you like without injunction. There is no option to delete the 'Title' or 'Description' in the client. Technically, if you were to use the API without the client there is no explicit reason to not delete those two fields since those fields only have special meaning to client but we should probably add deletion validators for Attributes and block deletion of those fields.

I'm unclear the usecase where removing these fields would be desirable.

@MazenBaroudi
Copy link
Author

@willdoran these fields are probably very helpful in humanitarian deployments
In other cases such as mine, I am collecting spatial data for research purposes and these two field are very confusing
If there is no technical need for these two field from your side, there will not be a problem to give clients the choice to keep or skip these fields
with regards/Mazen

@willdoran
Copy link
Contributor

Hi @MazenBaroudi,

These two fields or at least the title field are important for our client as the title is used as a link anchor between sections, for example, on our timeline view the list of posts link to their detail pages via the title. This does create a structural requirement for the title at least.

I have a couple of questions so I can understand your usecase a bit better if that's ok. Are you deploying the system yourself or are you using one of our cloud deployments? If it's the former, are you using both our client and api? If so then it may be possible for you to fork our client and adjust.

How are/were you deleting the title/description fields? It is possible to rename both of these fields if that would be useful.

@rjmackay it may be worth us revisiting using title for linking, it might be better to have some kind of icon that is the primary clickable link on post cards or that appears when title is unavailable.

@rjmackay
Copy link
Contributor

@willdoran removing them entirely is the key change in the #1335 but thats a big chunk of work since titles are used throughout the API and client. Its a bit further down the roadmap.

@MazenBaroudi
Copy link
Author

Hi @willdoran,
I am using the cloud deployment. I managed to change the name of the field and its position but that did not help me a lot as I don't have such long open questions in my survey.
here is the link of the survey if that helps:
https://takecareumea.ushahidi.io

Thanks and regards/Mazen

@willdoran
Copy link
Contributor

@MazenBaroudi Apologies I was away for the last 15 days. Could you walk me through exactly how you made the changes?

@willdoran
Copy link
Contributor

@rjmackay I think that this highlights a more general problem which is that users need to be able to define what appears in the post preview on timeline and elsewhere, and that as I said above we need to stop using certain fields as linkage points.

@rjmackay
Copy link
Contributor

Yup, but thats a much bigger chunk of work, and is really the issue attempting to be solved by "free form surveys" in #1335.

I don't think we can resolve this issue separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants