Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox "Make response private" doesn't works for "Description" field #1854

Closed
AntonShevchuk opened this issue Jul 9, 2017 · 5 comments
Closed
Labels

Comments

@AntonShevchuk
Copy link

AntonShevchuk commented Jul 9, 2017

Steps to reproduce the behaviour/error

Create new survey with default fields: "Title" and "Description"
Check "Make response private" for "Description"
Save it

Submit new survey and publish it

Expected behaviour

Open "Timeline" page
Show survey without description

Actual behaviour

Open "Timeline" page
Shown survey with description

@ryanchristo
Copy link
Contributor

ryanchristo commented Jul 13, 2017

This also applies to "Make response private" for "Title", which makes me think the toggle option for these two fields might not be intended. Should title and description have the ability to toggle "Make response private"? It would be a quick fix to remove the option from these two fields.

@AntonShevchuk For your particular use case, would it make sense to create a separate field and keep the description public or is it important that the description field itself is private?

@AntonShevchuk
Copy link
Author

@ryanchristo So, I can create new private field description but my users will be puzzled with two description fields

@ryanchristo
Copy link
Contributor

@AntonShevchuk You're right, that would be a little puzzling with two description fields. You can change the name of the description field and the new field but if it's the description field itself that you want to hide from users then removing the option to toggle would not help.

@AntonShevchuk
Copy link
Author

Yep, I really need this fix, this is last obstacle for migration from old version to new platform

@ryanchristo
Copy link
Contributor

ryanchristo commented Jul 17, 2017

@AntonShevchuk It looks like the team is exploring "free form surveys" (#1335), which would break from the current pattern of postcards (e.g. title, description, metadata). The title and description are not handled in the same way as the other fields (metadata), which is why Make response private is not working for the description field.

With the implementation of "free form surveys", all fields would function the same and the title and description fields could be hidden or never even added in the first place. It looks like the issue you came across adds another reason to make the switch.

I'll keep an eye out for a short-term solution but it looks like a long-term solution is in the works.

@rjmackay rjmackay added the Bug label Nov 3, 2017
@zube zube bot removed the Icebox label Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants