Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Monetization: there should be validation of the wallet address #4306

Closed
tuxpiper opened this issue Sep 3, 2021 · 3 comments
Closed

Web Monetization: there should be validation of the wallet address #4306

tuxpiper opened this issue Sep 3, 2021 · 3 comments

Comments

@tuxpiper
Copy link
Member

tuxpiper commented Sep 3, 2021

Describe the bug
There is no validation on what is provided to the "Wallet Address" input field of the Donation feature configuration.

As a result, deployers may be misled to believe they have correctly configured their wallet, but in reality, the interledger protocol doesn't have the necessary information to operate, and web monetization is not initialized in visitors' browsers. The deployer receives no donations.

Where was the bug observed
Deployments with donation feature enabled in staging and production.

To Reproduce
Steps to reproduce the behavior:

  1. Log in as an admin
  2. Go to Settings > Donation
  3. Under "Wallet Address" enter any text
  4. Click on "Enable Monetization"

Expected behavior
The client and the server should check that users' input conforms to the Interledger Protocol specification Payment Pointer syntax

Is there a workaround? What is it?
n/a

Screenshots
2021-09-03 12 43 37

URL / Environment where this happened
ushahidi.io - production

@helen-ndip
Copy link
Contributor

@Angamanga @tuxpiper can I work on this ?

@Angamanga
Copy link
Contributor

@helen-ndip I have assigned you to ushahidi/ussd-engine#48

@Angamanga
Copy link
Contributor

@yuktea Assigning this to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants