Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle properly Number abstraction and concrete types Real and Integer #752

Open
Tomaqa opened this issue Aug 23, 2024 · 0 comments
Open
Labels
performance Issue related to performance of OpenSMT QF_LIA Related to solving in QF_LIA logic
Milestone

Comments

@Tomaqa
Copy link
Member

Tomaqa commented Aug 23, 2024

Currently, everything is actually a real type so computation with integers is inefficient.
Moreover, sometimes the types may be used interchangeably although an explicit conversion would be more appropriate.

Consider using std::variant, maybe even with CRTP for defining a common interface of reals and integers, but it should not be necessary.
https://gist.github.com/olibre/3d0774df0f7a16e2da10fae2b2f26c4f

@Tomaqa Tomaqa added QF_LIA Related to solving in QF_LIA logic performance Issue related to performance of OpenSMT labels Aug 23, 2024
@Tomaqa Tomaqa added this to the v3.0.0 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Issue related to performance of OpenSMT QF_LIA Related to solving in QF_LIA logic
Projects
None yet
Development

No branches or pull requests

1 participant