Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image dimension checking is off-by-one #297

Closed
gfiumara opened this issue Aug 11, 2021 · 0 comments · Fixed by #302
Closed

Image dimension checking is off-by-one #297

gfiumara opened this issue Aug 11, 2021 · 0 comments · Fixed by #302
Labels
Milestone

Comments

@gfiumara
Copy link
Member

if (roiImg.cols <= fingerJetMinWidth) {

In FingerJet, the dimension bounds checking happens with asserts that are logically opposite of what we check. For instance, this line in FingerJet should be the opposite check of this line in NFIQ 2. Thus, NFIQ 2 should be checking if the width is < the min, not <=, and > the max, not >=.

(Submitted on behalf of the MITRE MTF and IQS Assessment team.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant