-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to handle profile resolution title addition? #579
Comments
I think I need to see an example of where it would be weird. The intent was to append the string " RESOLUTION" always at the end, after and outside any inline markup. The specification of how/whether to munge the profile title is certainly up for discussion. FWIW the reason |
I was thinking something like
Should that be: I think either is reasonable, but that makes testing a little harder. What about if it is: If |
@wendellpiez and @bradh I don't like the idea of changing the profile title. I believe it should be preserved as-is. |
That's fine. We can use this Issue to track a work item to revise the spec accordingly. |
@david-waltermire-nist @bradh @wendellpiez, while I agree with Dave's position as a recommended practice to avoid, I also feel this should be at the discretion of the tool developer. That said, I think it is important to provide both a machine-readable and human-readable way to know when working with a resolved profile vs. an actual catalog. I suspect that is the underlying goal for @bradh as well. At a minimum, a metadata prop could exist with the @name="resolved-profile" (possibly with a requirement to explicitly set the value to "yes", or just the existence of this prop could default to "yes" unless there is an explicit "no") For FedRAMP, we added a prop @name="marking" for document sensitivity marking. (I'm going to pitch for this to be included in our metadata upgrade). Perhaps something similar or identical could be used with a value of "RESOLVED PROFILE" to be displayed in proximity to the title. |
@david-waltermire-nist @bradh @brianrufgsa I like this idea okay (using property addition instead of title munging). It is consistent with what else we are doing. The title should be whatever reasonable and informed users downstream expect for the title.... It seems reasonable to aim for a set of rules that is unambiguous enough that, if two different resolutions by two conformant tools cannot be guaranteed to be the same, at least their variances are limited to what is predictable, such as the different timestamp (a feature not a bug). But no variances is better; and indicators that an OSCAL catalog was produced from a profile, etc. could be the same for everyone. If we want to stipulate that a tool can also "brand" or otherwise enhance a resolution by amending the metadata in other ways (which they would inevitably do differently), we should also say how and where this can be done. Maybe more properties?
|
The current profile resolution specification is silent on what to use as the title. This will result is variability between implementations. For example, After reading this discussion there is no strong demand to be more specific about title handling in the profile specification. We will close this and wait for a time where there are stronger opinions. |
The profile resolution spec for Instance metadata (3.4) includes:
Leaving aside the
last-modified
part which I'll address in a follow-up question, how should I add intitle
? If its a simple string, its easy - just append. However the content oftitle
is markup-line, which could contain various formatting (em
,b
,code
etc), or parameters. That could look a bit weird, or even broken, depending on where you choose to drop the "RESOLUTION" part.What logic should apply for complex profile titles?
The text was updated successfully, but these errors were encountered: