Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking if the profile-resolution files provided take into account the merge/custom function #897

Open
fmasson-oracle opened this issue Apr 14, 2021 · 4 comments
Labels
Aged A label for issues older than 2023-01-01 question Scope: Tooling and APIs Issues targeted at development of tooling and APIs to support OSCAL content creation and use.

Comments

@fmasson-oracle
Copy link

I am checking if the resolver-pipeline transformation scenarios provided with OSCAL1.0.0 RC2 release should work with the sample code provided on the https://pages.nist.gov/OSCAL/documentation/processing/profile-resolution/ page where you describe how controls could be restructured using the Merge/Custom element?

The resolver-pipeline transformation does not work as I get this error while doing the transformation: An empty sequence is not allowed as the first argument of opr:catalog-identifier()

This happens if I use this structure:

s1.1.3 s1.1.1 s1.1.4

I don't get the error if I don't use , but the new structure is not taken into account in the resolved-profile. I only get the controls in the order they appear from the imported catalog.

@david-waltermire
Copy link
Contributor

@fmasson-oracle Can you provide a small profile example that reproduces this bug?

@fmasson-oracle
Copy link
Author

fmasson-oracle commented Apr 21, 2021

Here is what will get resolved, but still results in getting the controls in the sequence they appear in the imported catalog:

image

And this is the the code that gives me the error when I run the resolver transformation:

image

@david-waltermire
Copy link
Contributor

@wendellpiez Can you look into this once you are done with the documentation. converter, and schema generation work?

@wendellpiez wendellpiez added the Scope: Tooling and APIs Issues targeted at development of tooling and APIs to support OSCAL content creation and use. label Feb 7, 2022
@wendellpiez
Copy link
Contributor

This needs to be accounted for in current unit testing see #1076 and #1087.

@fmasson-oracle sorry for delay (I am finding this picking up the resolver code). A possible mitigation occurred to me - would putting an id attribute (flag) on your group help?

In any case the usual cautions apply (ensure inputs are valid etc) and please feel free to raise again if this remains a problem.

todo: Build tests both with and without (optional?) ID on new groups in custom. Report a useful error when it is missing.

@aj-stein-nist aj-stein-nist removed this from the v1.1.0 milestone Jul 27, 2023
@Compton-US Compton-US added the Aged A label for issues older than 2023-01-01 label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aged A label for issues older than 2023-01-01 question Scope: Tooling and APIs Issues targeted at development of tooling and APIs to support OSCAL content creation and use.
Projects
Status: Todo
Development

No branches or pull requests

5 participants