Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSCAL reference documentation - empty Constraints #912

Closed
iMichaela opened this issue Apr 22, 2021 · 5 comments · Fixed by #948
Closed

OSCAL reference documentation - empty Constraints #912

iMichaela opened this issue Apr 22, 2021 · 5 comments · Fixed by #948
Assignees
Labels
bug Scope: Documentation This issue relates to OSCAL documentation. Scope: Modeling Issues targeted at development of OSCAL formats

Comments

@iMichaela
Copy link
Contributor

Describe the bug

In the OSCAL reference documentation, there are empty Constraints with statements reading:
> Constraints that may apply to the data value of this element (in context):
which expand to nothing, leaving the statement incomplete.

Who is the bug affecting?

What is affected by this bug?

When does this occur?

How do we replicate the issue?

Go to any 'reference' page and use browser search to find the statements listed above.

If applicable, add screenshots to help explain your problem.}

Expected behavior (i.e. solution)

Other Comments

@iMichaela iMichaela added the bug label Apr 22, 2021
@david-waltermire david-waltermire added Scope: Documentation This issue relates to OSCAL documentation. Scope: Modeling Issues targeted at development of OSCAL formats labels Apr 30, 2021
@david-waltermire
Copy link
Contributor

@iMichaela I did an XPath search of the metaschemas using //(*:constraints|*:constraint)[not(*)][not(normalize-space())]. I found 3 instances, which might be causing this, but its hard to tell without more specifics.

Can you provide a few specific examples of where you are seeing this?

@david-waltermire david-waltermire self-assigned this May 4, 2021
@iMichaela
Copy link
Contributor Author

@david-waltermire-nist There are multiple instances of this error on each reference page for the XML formats (see bottom of the image below).

image

assessment results model: 16 instances (the first one is under addr-line - see above)
poa&m: 15 instances
assessment plan: 14
component definition model: 12
ssp: 19
profile model: 14
control model: 13

@wendellpiez
Copy link
Contributor

@david-waltermire-nist is probably correct as to the upstream cause. However the data anomaly should be tolerated (and not produce the empty stub). Removing placeholders from the data then becomes an option.

Let's see to it this is corrected with usnistgov/metaschema-xslt#17.

@wendellpiez
Copy link
Contributor

Provision to prevent the unwanted output for 'stub' content has been made in PR usnistgov/metaschema/#135.

@david-waltermire
Copy link
Contributor

The reference documentation on the website has been completely revamped. This new documentation will be released with OSCAL 1.0.0. This issue was addressed by PR #948.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Scope: Documentation This issue relates to OSCAL documentation. Scope: Modeling Issues targeted at development of OSCAL formats
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants