Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in feature_space_size() ? #23

Open
yoid2000 opened this issue Jan 31, 2024 · 1 comment
Open

Bug in feature_space_size() ? #23

yoid2000 opened this issue Jan 31, 2024 · 1 comment

Comments

@yoid2000
Copy link

In the routine feature_space_size(), you have this code:

SDNist/sdnist/report/dataset/__init__.py

Lines 68 to 69 in b06d361

elif col in ['PUMA', 'DENSITY']:
size = size * len(target_df['PUMA'].unique())

Shouldn't it be this?

        elif col in ['PUMA', 'DENSITY']:
            size = size * len(target_df[col].unique())
@kbtriangulum
Copy link
Collaborator

Nice catch Paul! I will add the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yoid2000 @kbtriangulum