We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is a bug whereby sdnist crashes if there are zero values in the synthetic data for DENSITY.
The problem is that, although you bottom code DENSITY to zero here:
SDNist/sdnist/report/dataset/binning.py
Line 102 in 8430da9
The left-most bin boundary of 0.0 is not inclusive at the pd.cut() function:
pd.cut()
Lines 105 to 109 in 8430da9
As a result, any 0.0 DENSITY values in the synthetic data are set to NaN, and then later in transform.py when the values are set to numeric:
transform.py
SDNist/sdnist/report/dataset/transform.py
Line 32 in 8430da9
The NaN values cause a crash.
NaN
The solution is to make the left-most bin boundary inclusive:
if update: d['DENSITY'] = pd.cut(d['DENSITY'], bins=bins, labels=labels, include_lowest=True) return d else: d['binned_density'] = pd.cut(d['DENSITY'], bins=bins, labels=labels, include_lowest=True)
The text was updated successfully, but these errors were encountered:
No branches or pull requests
There is a bug whereby sdnist crashes if there are zero values in the synthetic data for DENSITY.
The problem is that, although you bottom code DENSITY to zero here:
SDNist/sdnist/report/dataset/binning.py
Line 102 in 8430da9
The left-most bin boundary of 0.0 is not inclusive at the
pd.cut()
function:SDNist/sdnist/report/dataset/binning.py
Lines 105 to 109 in 8430da9
As a result, any 0.0 DENSITY values in the synthetic data are set to NaN, and then later in
transform.py
when the values are set to numeric:SDNist/sdnist/report/dataset/transform.py
Line 32 in 8430da9
The
NaN
values cause a crash.The solution is to make the left-most bin boundary inclusive:
The text was updated successfully, but these errors were encountered: