Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More resilient XML comparison utility for CI/CD process validation #110

Closed
3 tasks
wendellpiez opened this issue Dec 21, 2020 · 3 comments
Closed
3 tasks
Assignees
Labels
enhancement New feature or request

Comments

@wendellpiez
Copy link
Collaborator

User Story:

(If this Issue should be in OSCAL repo let me know)

Currently we validate certain processes such as the data conversions by running a comparison utility over XML (or JSON?) files, showing changes between XML inputs and "the same" data coming back from processing.

At present this utility is sensitive to both changes in whitespace (which are tricky to prevent in a Markup->Markdown->Markup transition) and OSCALisms such as the fact that what goes in as i, comes back as em.

Testing could be made easier if false hits related to these discrepancies did not occur.

Goals:

Review functionality of the comparison tool in view of requirements. At time of writing we see both whitespace discrepancies (but see #108) and the casting of strong/em and b/i.

Dependencies:

Issues #108 and usnistgov/metaschema-xslt#16 should be addressed first as they may significantly mitigate this problem.

Acceptance Criteria

  • All website and readme documentation affected by the changes in this issue have been updated. Changes to the website can be made in the docs/content directory of your branch.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.
@wendellpiez wendellpiez added the enhancement New feature or request label Dec 21, 2020
@david-waltermire
Copy link
Collaborator

david-waltermire commented Apr 12, 2022

This relates to testing metaschema-based XML and JSON conversion (#51, #53, usnistgov/metaschema-xslt#16). This work should be done as part of building out better unit testing (#201, usnistgov/metaschema-xslt#20).

@aj-stein-nist
Copy link
Collaborator

Per discussion, it does seem like the round-tripping scripts and harness is in the OSCAL repo not the Metaschema repo, at least according to current develop.

The question for me in this issue if closed, or related issues, is this a core feature/property of OSCAL that leverages Metaschema that manages to make it possible or this a feature that is core, guaranteed by Metaschema, and should be documented, implemented, and tested in this repo and Metaschema implementations?

@david-waltermire
Copy link
Collaborator

This relates to the OSCAL validate-content-conversion-round-trips.sh script. Any work on round tripping should be done related to OSCAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants