Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request validation #48

Open
2 of 13 tasks
wunc opened this issue May 12, 2022 · 0 comments
Open
2 of 13 tasks

Request validation #48

wunc opened this issue May 12, 2022 · 0 comments
Assignees
Labels
🐘 php Pull requests that update Php code 🔒 security Security-related

Comments

@wunc
Copy link
Collaborator

wunc commented May 12, 2022

There are some gaps in our request validation. We need to have request validation for all routes that read data (API and others).

This should probably be done as FormRequests for the most part.

  • ProfilesController > ProfileUpdateRequest (done in Profile data update validations #88)
  • TagsController > TagsUpdateRequest (done in Error fix to remove all tags and data type and presence validation #91)
  • TagsController > TagsStoreRequest (maybe reuse the TagsUpdateRequest?)
  • TagsController > TagsSearchRequest (also maybe convert to LiveWire later)
  • ProfilesController > ProfileSearchRequest (see Sentry PROFILES-4X)
  • ProfilesController > ProfileShowRequest
  • SchoolsController > SchoolUpdateRequest
  • SettingsController > SettingsUpdateRequest
  • SettingsController > ImageUpdateRequest
  • LogsController > LogSearchRequest (although, this should probably be implemented as LiveWire instead)
  • StudentsController > StudentStatusRequest
  • StudentsController > StudentUpdateRequest
  • UsersController > UserUpdateRequest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐘 php Pull requests that update Php code 🔒 security Security-related
Projects
None yet
Development

No branches or pull requests

2 participants