-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] Close VM window after it powers off #2410
Comments
Re-opening due to #2466 introduced with this change. |
Hello, Cheers, |
@osy is this just a normal regression / bug that will be fixed in the future? When a user shuts down a VM normally and no errors appear, I'm having a hard time understanding why someone would want the VM window not to close. |
Actually I use this quite often. I initiate a shutdown from the guest. Wait until it powers off. Then I start the guest again. |
OK, thanks for the answer, I guess that makes sense, but one could argue that you would still be able to just (re)start the VM normally from the VM list if this default behavior was changed. Or just use I wonder how common your use case is, I mean do you represent the majority here, or are there even more people (like me) who are just annoyed that shutting down a VM doesn't actually completely "shut it down"? I guess there's no way to know for sure. I'm obviously biased, but I personally would still automatically close the VM window if the VM is shut down. edit: Come to think of it, depending on the implementation details, I guess restarting the VM could be interpreted as kind of shutting down the VM (and then immediately restarting it). I'm pretty sure nobody wants the VM window to be closed when restarting, only when actually shutting down "for good". |
The technical reason is that right now we don’t have a way for the UI to know if it’s shut down by the user or due to an error. (The error pop up is asynchronous). So previously, we close the window and also the error closed. This can be worked around but would require more work than just closing the window. |
Currently, after a VM powers off on macOS, its window stays on screen with a huge Play button. In my opinion it would be better if the window would close automatically.
The text was updated successfully, but these errors were encountered: