Clicking the share button causes UTM to crash

[longwa]

On the main view with VM's listed to the left and status to the right, clicking the Share icon causes UTM to crash instantly.

This seems to happen for all of my VM's (both are x86, "Start from Scratch" on M1).

Configuration

• UTM Version: 2.3.1
• OS Version: 11.6
• Apple Silicon

UTM_2021-10-26-121857.crash.log

[longwa]

The VM's are Oracle Linux 7.9 and CentOS 7 both with x86_64 emulation.

[osy]

@ktprograms is this related to #3056

[ktprograms]

@osy It's a Unexpectedly found nil while unwrapping an Optional value at

UTM/Platform/macOS/SavePanel.swift

Line 58 in 16e3a3e

savePanel.beginSheetModal(for: nsView.window!) { result in

(Which was changed in cb7bba8)

For some reason in updateNSView(_:context:), nsView.window is still nil.

[osy]

That means the view hasn't been loaded into a window yet. My guess is the layout system was preloading the view.

[ktprograms]

Also when reproducing the error locally, Xcode has this runtime error/notice:
NSHostingView is being laid out reentrantly while rendering its SwiftUI content. This is not supported and the current layout pass will be skipped.

[ktprograms]

That means the view hasn't been loaded into a window yet. My guess is the layout system was preloading the view.

@osy so should there be an if let and use savePanel.begin { result in if nsView.window is still nil?

[osy]

Also when reproducing the error locally, Xcode has this runtime error/notice:
NSHostingView is being laid out reentrantly while rendering its SwiftUI content. This is not supported and the current layout pass will be skipped.

Can you try wrapping data.alertMessage = with Dispatch.main.async? I think it's complaining that a non-main thread is modifying the SwiftUI state.

That means the view hasn't been loaded into a window yet. My guess is the layout system was preloading the view.

@osy so should there be an if let and use savePanel.begin { result in if nsView.window is still nil?

I think if nsView.window is nil, we just return. It means the view was being laid out before the user clicked on the button.

[ktprograms]

Can you try wrapping data.alertMessage = with Dispatch.main.async? I think it's complaining that a non-main thread is modifying the SwiftUI state.

@osy when I do that, the SavePanel pops up, and then within half a second Xcode shows the unwrapping nil fatal error.

Edit: If I add the if let window = nsView.window then it works but seems to take about twice as long to pop up

[osy]

Are you sure the nil unwrapping is at nsView.window? It seems weird that the sheet modal shows up if window is nil.

[ktprograms]

Yes, it's at nsView.window!.

[osy]

Btw this doesn't seem to happen on macOS Monterey for me.