Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICall crash with 5 method args limit #491

Closed
chippmann opened this issue Aug 27, 2023 · 1 comment · Fixed by #493
Closed

ICall crash with 5 method args limit #491

chippmann opened this issue Aug 27, 2023 · 1 comment · Fixed by #493
Labels
bug Something isn't working topic:core

Comments

@chippmann
Copy link
Contributor

We have a method args limit of 5 which we enforce with:

#ifdef DEBUG_ENABLED
    JVM_CRASH_COND_MSG(args_size > VARIANT_ARG_MAX, vformat("Cannot have more than %s arguments for method call.", VARIANT_ARG_MAX));
#endif

This leads to api call to fail:

ERROR: Godot-JVM: Cannot have more than 5 arguments for method call but tried to call method "ENetMultiplayerPeer::create_client" with 6 args
@chippmann
Copy link
Contributor Author

It seems godot changed the max to 8 a while ago: godotengine/godot#54188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working topic:core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant