Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using rng-browser.js: global is not defined (3.1.0) #252

Closed
cecemel opened this issue Jan 12, 2018 · 4 comments
Closed

using rng-browser.js: global is not defined (3.1.0) #252

cecemel opened this issue Jan 12, 2018 · 4 comments

Comments

@cecemel
Copy link

cecemel commented Jan 12, 2018

Hi,

when using the library in chrome/firefox, I get:

ReferenceError: global is not defined

Seems this line is an issue:
https://github.com/kelektiv/node-uuid/blob/v3.1.0/lib/rng-browser.js#L7

It seems, this should be the line: https://developer.mozilla.org/en-US/docs/Web/API/Window/crypto

Or am I mistaken?

@broofa
Copy link
Member

broofa commented Jan 12, 2018

Yeah, sorry about this. #247 fixes this (I believe). There are a handful of PRs waiting for approval before we push out a new release.

ping @defunctzombie @vvo - Can one/both of you guys take a pass on the open PRs and approve/comment. We need to get a new version out.

@cecemel
Copy link
Author

cecemel commented Jan 12, 2018

thx

@vvo
Copy link

vvo commented Jan 15, 2018

I did some review, what I could, all good @broofa

@broofa
Copy link
Member

broofa commented Jan 17, 2018

Fixed in v3.2.1 (published)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants