date: forbid conflicting options

Author: BenWiederhake

src/uu/date/src/date.rs

@@ -319,6 +319,8 @@ pub fn uu_app() -> Command {
                 .long(OPT_DATE)
                 .value_name("STRING")
                 .overrides_with(OPT_DATE)
+                .conflicts_with(OPT_FILE)
+                .conflicts_with(OPT_REFERENCE)
                 .help("display time described by STRING, not 'now'"),
         )
         .arg(
@@ -328,6 +330,7 @@ pub fn uu_app() -> Command {
                 .value_name("DATEFILE")
                 .value_hint(clap::ValueHint::FilePath)
                 .overrides_with(OPT_FILE)
+                .conflicts_with(OPT_REFERENCE)
                 .help("like --date; once for each line of DATEFILE"),
         )
         .arg(
@@ -340,13 +343,16 @@ pub fn uu_app() -> Command {
                 ]))
                 .num_args(0..=1)
                 .default_missing_value(OPT_DATE)
+                .conflicts_with(OPT_RFC_EMAIL)
+                .conflicts_with(OPT_RFC_3339)
                 .help(ISO_8601_HELP_STRING),
         )
         .arg(
             Arg::new(OPT_RFC_EMAIL)
                 .short('R')
                 .long(OPT_RFC_EMAIL)
                 .help(RFC_5322_HELP_STRING)
+                .conflicts_with(OPT_RFC_3339)
                 .action(ArgAction::SetTrue),
         )
         .arg(
@@ -378,6 +384,9 @@ pub fn uu_app() -> Command {
                 .long(OPT_SET)
                 .value_name("STRING")
                 .overrides_with(OPT_SET)
+                .conflicts_with(OPT_DATE)
+                .conflicts_with(OPT_FILE)
+                .conflicts_with(OPT_REFERENCE)
                 .help(OPT_SET_HELP_STRING),
         )
         .arg(

tests/by-util/test_date.rs

@@ -595,3 +595,27 @@ fn test_repeat_reference_older_last() {
         .stdout_only("2001-02-03\n")
         .no_stderr();
 }
+
+#[test]
+fn test_incompatible_args() {
+    for args in [
+        // Input with other input
+        vec!["-d", "now", "-f", "foo"],
+        vec!["-d", "now", "-r", "foo"],
+        vec!["-f", "foo", "-r", "foo"],
+        // Format with other format
+        vec!["-I", "-R"],
+        vec!["-I", "--rfc-3339=date"],
+        vec!["-R", "--rfc-3339=date"],
+        // Input with --set
+        vec!["-d", "now", "-s", "now"],
+        vec!["-r", "foo", "-s", "now"],
+        vec!["-f", "foo", "-s", "now"],
+    ] {
+        new_ucmd!()
+            .args(&args)
+            .fails()
+            .no_stdout()
+            .stderr_contains(" cannot be used with ");
+    }
+}