Skip to content

Commit d27c8b4

Browse files
naoNao89RenjiSann
authored andcommitted
fix: parameterize SHA2/SHA3 benchmarks to use valid lengths
- Use length as parameter instead of hardcoded values - Add algorithm-specific lengths for each algorithm (224, 256, 384, 512 bits) - Resolves benchmarks running too fast (<500µs) due to invalid length parameters - All algorithms now produce meaningful hash outputs with proper timing
1 parent c750bff commit d27c8b4

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/uu/cksum/benches/cksum_bench.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ macro_rules! bench_algorithm {
2323
});
2424
}
2525
};
26-
($algo_name:ident, $algo_str:expr, length) => {
26+
($algo_name:ident, $algo_str:expr, $length:expr) => {
2727
#[divan::bench]
2828
fn $algo_name(bencher: Bencher) {
2929
let data = text_data::generate_by_size(100, 80);
@@ -36,7 +36,7 @@ macro_rules! bench_algorithm {
3636
"--algorithm",
3737
$algo_str,
3838
"--length",
39-
"1048576",
39+
$length,
4040
file_path.to_str().unwrap(),
4141
],
4242
));
@@ -96,14 +96,14 @@ bench_algorithm!(cksum_crc, "crc");
9696
bench_algorithm!(cksum_crc32b, "crc32b");
9797
bench_algorithm!(cksum_md5, "md5");
9898
bench_algorithm!(cksum_sha1, "sha1");
99-
bench_algorithm!(cksum_sha2, "sha2", length);
100-
bench_algorithm!(cksum_sha3, "sha3", length);
99+
bench_algorithm!(cksum_sha2, "sha2", "256");
100+
bench_algorithm!(cksum_sha3, "sha3", "256");
101101
bench_algorithm!(cksum_blake2b, "blake2b");
102102
bench_algorithm!(cksum_sm3, "sm3");
103-
bench_algorithm!(cksum_sha224, "sha224");
104-
bench_algorithm!(cksum_sha256, "sha256");
105-
bench_algorithm!(cksum_sha384, "sha384");
106-
bench_algorithm!(cksum_sha512, "sha512");
103+
bench_algorithm!(cksum_sha224, "sha224", "224");
104+
bench_algorithm!(cksum_sha256, "sha256", "256");
105+
bench_algorithm!(cksum_sha384, "sha384", "384");
106+
bench_algorithm!(cksum_sha512, "sha512", "512");
107107
bench_algorithm!(cksum_blake3, "blake3");
108108
bench_shake_algorithm!(cksum_shake128, "shake128", Shake128);
109109
bench_shake_algorithm!(cksum_shake256, "shake256", Shake256);

0 commit comments

Comments
 (0)