Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm: On Windows, rm -rf * doesn't do anything. #1274

Closed
TheGoddessInari opened this issue Aug 4, 2018 · 6 comments
Closed

rm: On Windows, rm -rf * doesn't do anything. #1274

TheGoddessInari opened this issue Aug 4, 2018 · 6 comments

Comments

@TheGoddessInari
Copy link
Contributor

It doesn't return an error, but also doesn't remove any files or directories.

@Arcterus
Copy link
Collaborator

Arcterus commented Aug 6, 2018

This is probably due to Windows shells not expanding globs. I’m not sure if we should expand the globs ourselves on Windows or just leave the behavior as is.

It should at least return an error on the glob right now because it’s not being expanded, so that is an issue.

@rivy
Copy link
Member

rivy commented Aug 29, 2018

This bugged me as well. So, I fixed it.

With just a small set of changes, localized to 'uucore', I was able to add command line globbing for windows targets to all the utilities.

I've just opened PR#1281 with the patches.

@rivy
Copy link
Member

rivy commented Apr 6, 2019

Fixed in PR#1281.
This can be closed.

@Arcterus
Copy link
Collaborator

Arcterus commented Apr 6, 2019

Thanks for reminding me!

@Arcterus Arcterus closed this as completed Apr 6, 2019
@TheGoddessInari
Copy link
Contributor Author

Actually, one problem with #1281 is that it doesn't use similar globbing rules. For instance, it unexpectedly deletes hidden directories, like .git when using a basic rm -rf *. That's pretty unexpected behavior. Just noticed this, but I suppose I should open a new issue.

@Arcterus
Copy link
Collaborator

@TheGoddessInari yeah, that is definitely an issue. I also just noticed that ~ doesn't expand, which is another problem. If you could open an issue that'd be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants