Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent indentation amongst files #3

Open
KacperKubara opened this issue Nov 3, 2020 · 3 comments
Open

Inconsistent indentation amongst files #3

KacperKubara opened this issue Nov 3, 2020 · 3 comments

Comments

@KacperKubara
Copy link

Hi,

Just wanted to let you know that I've noticed that there are inconsistent indentations amongst files (2 or 4 spaces). For example, train_mlp_numpy.py (4 space indentation) and mlp_numpy.py (2 space indentation). Some Python IDEs don't respond to that well and it might potentially break someone's code.

@Gabri95
Copy link
Contributor

Gabri95 commented Nov 4, 2020

Hi @KacperKubara

thanks for reporting this.
Are you referring to the doc strings? The rest of the code seems to have 4 spaces indentation everywhere to me.

Best,
Gabriele

@KacperKubara
Copy link
Author

Some of the files that we are given have only code skeleton and docstrings so I suppose that yes? Basically, when I do a fresh clone of the repo, the indentation indentation differs. mlp_numpy.py, mlp_pytorch.py, cifar10_utils.py, convnet_pytorch.py, custom_layernorm.py, modules.py have 2 space indentation. The rest of the files have 4 space indentation.

It's probably not a big issue and, at least VScode, has no problems with that. But it seems like something that be quite quickly fixed as well.

Below is the screenshot of the space indentation difference, hope it will clarify the problem.

image

Anyway, it can be easily fixed by changing the indentation options in the VSCode as below
image

@Gabri95
Copy link
Contributor

Gabri95 commented Nov 6, 2020

Hi @KacperKubara ,

In both images, all lines seem to have 4 spaces indentation to me.

I have also tried to pull the code for the repository again and all files seem to have 4 spaces indentation (I checked it with gedit, no advanced IDE like VSCode or PyCharm).

I am not sure what to fix then

Best,
Gabriele

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants