Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace raco submodule with install/develop #301

Open
bmyerz opened this issue Oct 2, 2015 · 2 comments
Open

Replace raco submodule with install/develop #301

bmyerz opened this issue Oct 2, 2015 · 2 comments
Labels

Comments

@bmyerz
Copy link
Member

bmyerz commented Oct 2, 2015

@senderista and I discussed removing raco as a submodule. The reason is 1) difficulty developing raco (replace submodule with symlink or keep changing submodule commit hash for raco...) and 2) that it would be nice to point myria-web deployment at releases of raco.

Workflow for deploying/developing myria-web without Raco hacking:

  • pip install raco before running myria-web
  • or cd raco; python setup.py install

Workflow for developing myria-web with Raco hacking:

  • cd raco; python setup.py develop
@bmyerz bmyerz added the refactor label Oct 2, 2015
@bmyerz bmyerz changed the title Replace raco submodule with pip install Replace raco submodule with install/develop Oct 2, 2015
@domoritz
Copy link
Member

domoritz commented Nov 1, 2015

The problem was app engine, right?

@senderista
Copy link
Contributor

Yes, it's been a while since I looked at this, but I think GAE restrictions on third-party libraries were the original reason for including raco as a submodule. We might be able to install it via pip using a lib directory under the GAE root directory: https://cloud.google.com/appengine/docs/python/tools/libraries27?hl=en#vendoring. Per the instructions on this page, we would add the following to appengine_config.py:

from google.appengine.ext import vendor

# Add any libraries installed in the "lib" folder.
vendor.add('lib')

Then we would add the desired raco version to requirements.txt and run pip install -t lib -r requirements.txt before deploying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants