Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow username/password auth #34

Open
justaugustus opened this issue Dec 25, 2022 · 2 comments
Open

Don't allow username/password auth #34

justaugustus opened this issue Dec 25, 2022 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@justaugustus
Copy link
Contributor

No description provided.

@justaugustus justaugustus added the bug Something isn't working label Dec 25, 2022
@justaugustus justaugustus mentioned this issue Dec 25, 2022
8 tasks
@justaugustus justaugustus added this to the v0.1.0 milestone Dec 25, 2022
@lgecse
Copy link
Contributor

lgecse commented Aug 7, 2023

@justaugustus What we do now is username + APIToken basic auth. Should we remove this capability completely from the tool?

My recommendation is to keep it in the tool, but rename the config at least from jira-password to jira-apitoken. We are not allowing already to use the tool with jira username and password line 107 in jira.go

@rappizs
Copy link
Contributor

rappizs commented Aug 7, 2023

Should we remove this capability completely from the tool?

I don't know how we could remove this auth method since other than this Jira only supports OAuth, which although is more secure, isn't really useful if we want to run the tool in an automatised way.

At the moment we support this basic auth (Basic auth for REST APIs) and OAuth 1.0a which is deprecated and should be replaced, see #31 (OAuth 1.0a for REST APIs (Legacy)).

I agree with @lgecse that we should keep this method and rename the jira-pass config value, since it's not really a password but an API token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants