Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@popicons/react-native doesn't work #4

Closed
im-adithya opened this issue Sep 11, 2024 · 2 comments
Closed

@popicons/react-native doesn't work #4

im-adithya opened this issue Sep 11, 2024 · 2 comments

Comments

@im-adithya
Copy link

Firstly, thanks for the clean set of icons 🙌

Coming to the issues,

  • The icons are typed as PopiconsHomeStyleDuotone, PopiconsHomeStyleSolid, PopiconsHomeStyleLine etc. in popicons.d.ts but are exported as PopiconsHomeDuotone, PopiconsHomeSolid, PopiconsHomeLine etc. in popicons.js in the npm package. This is leading to undefined errors as TS is forcing to import PopiconsHomeStyleLine but it doesn't actually exists. Importing PopiconsHomeLine works but it gives a TS error 😄
  • Also it gives Property 'React' doesn't exist error even after importing PopiconsHomeLine instead of PopiconsHomeStyleLine which was resolved after adding import React from 'react'; in popicons.js (or maybe you are running an older version of React?)

Would be great if you can have a look!

@filipgrkinic
Copy link
Collaborator

@im-adithya thanks for bringing this up, it was indeed a typo in the build process, just published an update:
https://www.npmjs.com/package/@popicons/react-native

@im-adithya
Copy link
Author

im-adithya commented Oct 7, 2024

Awesome, thanks!

I tried this just now and I still failed to get this working, I get this error, importing React should fix this issue

And a small nit, I think you missed PopiconsCircleExclamationLine (didn't check the rest) 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants