Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CE Binder: Improve documentation on the not working bind(ValueProvider, Setter) api #60

Open
stefanuebe opened this issue Mar 4, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@stefanuebe
Copy link

Is your feature request related to a use case? Please describe.
Currently it is not possible to use the Binder method bind(ValueProvider<BEAN, TARGET> getter, Setter<BEAN, TARGET> setter).

This is mentioned in the binder docs, but not in the quick start nor in the api docs. Therefore, when using the quick start or simply "trying it out" you will most likely run into an issue as the reference based bind version is mostly preferred.

Describe the solution you'd like

  • override the not working bind() method
  • make it deprecated
  • describe in the respective api docs that this method is not supported
  • add an info in the quickstart
@stefanuebe stefanuebe added the enhancement New feature or request label Mar 4, 2022
@stefanuebe stefanuebe changed the title CE Binder: Improve documentation on bind(ValueProvider, Setter) not working CE Binder: Improve documentation on the not working bind(ValueProvider, Setter) api Mar 4, 2022
@Legioth
Copy link
Member

Legioth commented Mar 4, 2022

This is more complicated to do than what it seems like at a glance since we'd have to override the regular com.vaadin.flow.data.binder.Binder.BindingBuilder interface and then also override all methods that return that type to instead return the overriding type.

@stefanuebe
Copy link
Author

Hmm, true, haven't thought about that. Then let's reduce this issue to "extend quickstart docs".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants