Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom component in GridPro should support HasValueAndElement instead of AbstractField #3023

Closed
probert94 opened this issue Apr 15, 2022 · 1 comment · Fixed by #3207
Closed
Labels
enhancement New feature or request

Comments

@probert94
Copy link

probert94 commented Apr 15, 2022

Describe your motivation

I would like to use custom editor components in the GridPro and some of those components extend Composite or AbstractCompositeField. Unfortunately the GridPro only accepts AbstractField as custom editor component.

Describe the solution you'd like

After taking a look at the source, it seems like HasValueAndElement could be used instead of AbstractField.
HasValueAndElement supports all the needed methods (getElement, getValue, setValue) and as it is an interface, it could be used for every component.
As AbstractField already implements HasValueAndElement, the change should be compatible with the current version.

Describe alternatives you've considered

The only alternative seems to be to rewrite all the components to extend AbstractField. In the worst case this is not even possible, as the components might come from a third party library.

@juuso-vaadin
Copy link

A customer has requested this in order to be able to use LookupField add-on in GridPro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants