Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuBar - SubMenu item flickers open in bottom right corner after upgrading to Vaadin 24.4.1 #6368

Closed
F-Kamp opened this issue Jun 13, 2024 · 1 comment · Fixed by vaadin/web-components#7524

Comments

@F-Kamp
Copy link

F-Kamp commented Jun 13, 2024

Description

Clicking on a MenuBar's item with a SubMenu item displays the sub menu in the bottom right corner of the browser for a few milliseconds. This bug started appearing after upgrading from Vaadin 24.3.11 to 24.4.1.

Recording.2024-06-13.102938.mp4

Expected outcome

The sub menu item should only be visible below the menu bar's item.

Minimal reproducible example

@Route("menuBarDemo")
public class MenuBarDemo extends VerticalLayout {


    @Serial
    private static final long serialVersionUID = 6767738777541856721L;

    public MenuBarDemo() {
        setSizeFull();
        getStyle().set("background", "gray");

        var menuBar = new MenuBar();

        var menuItem = menuBar.addItem("Item1");
        menuItem.getSubMenu().addItem("SubItem1");

        this.add(menuBar);
    }

}

Steps to reproduce

Add the snippet, click on the menu bar

Environment

Vaadin version(s): 24.4.1
OS: Windows 11

Browsers

Chrome, Firefox, Edge

@sissbruecker
Copy link
Contributor

sissbruecker commented Jun 18, 2024

Can confirm, it's a regression in 24.4 due to vaadin/web-components#7015

Edit: Changes in vaadin-menu-bar-mixin.js specifically: https://github.com/vaadin/web-components/pull/7015/files#diff-8e5477dc413052da5b0dfe6bbd6c60443cfad85885db5a12a589b053310a58c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants